Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Enable experimental Vulkan testing on macOS #3391

Open
wants to merge 1 commit into
base: feature-hgi-vulkan
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

  • Add PXR_ENABLE_EXPERIMENTAL_TESTS (off by default) to enable more graphics tests.
    • Building with it enabled, you now have access to way more tests.
    • Currently only used on macOS. I'll have Windows support ready a bit later.
  • Cleanup use of PXR_ENABLE_GL_SUPPORT and PXR_BUILD_GPU_SUPPORT.
    • PXR_BUILD_GPU_SUPPORT is only true if PXR_ENABLE_GL_SUPPORT is true: cleanup redundant checks.
    • Add or correct various PXR_ENABLE_GL_SUPPORT checks.
  • Remove X11 requirement.
    • Create a null GL context when X11 isn't available, so tests can still run (but without HgiGL support).
  • Various changes to make HgiVulkan work on macOS. Using Lavapipe you can run the full test suite.
    • Enable GLSL support on macOS. This will also be needed by HgiWebGPU.
    • Add OpenGL 1.4 support to HgiInterop and use a VertexArray, as required by Apple OpenGL.
    • The vast majority of tests are passing. Most are failing because tiny differences compared to the baseline, minor issues with Lavapipe, or unreliable tests (mostly dependency on the order of unordered collection).
    • This PR focuses on getting the tests to run, not to pass.
  • Fix testHdStCodeGen and testHdStQuadrangulation crashing due to undefined static destruction order.

Link to proposal (if applicable)

  • N/A

Fixes Issue(s)

  • N/A

Checklist

[ ] I have created this PR based on the dev branch

[X] I have followed the coding conventions

[X] I have added unit tests that exercise this functionality (Reference:
testing guidelines)

[X] I have verified that all unit tests pass with the proposed changes

[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10387

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DDoS DDoS force-pushed the adsk/feature/macos-vk-testing branch from bbca86f to f52a686 Compare November 4, 2024 17:33
pixar-oss pushed a commit that referenced this pull request Nov 26, 2024
Autodesk: Enable experimental Vulkan testing on macOS
- Add OpenGL 3.1/GLSL 1.4 support to HgiInterop and use a VertexArray, as required by Apple OpenGL.

See #3391

(Internal change: 2349264)
pixar-oss pushed a commit that referenced this pull request Nov 26, 2024
Autodesk: Enable experimental Vulkan testing on macOS
- Create a null GL context when X11 isn't available, so tests can still run
  (but without HgiGL support).

Pixar note: The original PR had both the X11 GL context and the null GL context
in new separate files, but I put them both in testGLContext.cpp to simplify
the build scripts and hide the details.

See #3391

(Internal change: 2349272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants